-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated warning printout logic for Sign with --allow-referrers-api flag #682
Conversation
Signed-off-by: Patrick Zheng <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #682 +/- ##
==========================================
+ Coverage 59.13% 59.15% +0.01%
==========================================
Files 40 40
Lines 2183 2184 +1
==========================================
+ Hits 1291 1292 +1
Misses 795 795
Partials 97 97
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should we also add a check that |
@priteshbandi Then that would be an error for the user instead of dropping the |
…sign Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This quick PR updates the printout logic for
sign
, when user enables--allow-referrers-api
.The warning should be valid only when target artifact is stored in a
registry
.If the user enables
--oci-layout
, i.e., target artifact is stored in an OCI layout, enabling--allow-referrers-api
won't take any effect (this is because oci.Store does not support Referrers API yet). In this case, we shouldn't print out the warning.The fix: During
Sign
, mark flags--oci-layout
and--allow-referrers-api
mutually exclusive.Resolves #683.