Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): E2E test cases for OCI layout #692

Merged
merged 6 commits into from
Jun 5, 2023

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented May 26, 2023

Feat:

  • add E2E test framework oci layout support: generate isolated oci layout dynamically for each test case

Fix:

  • update oci layout test to use isolated oci layout (previsouly the oci layout is shared by multiple test cases)
  • the assertion target for TLS and --insecure-registry test cases

Test:

  • added new test cases for notation list --oci-layout

Resolves #693
Signed-off-by: Junjie Gao [email protected]

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Merging #692 (e2347cd) into main (ebfb9ef) will increase coverage by 0.13%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
+ Coverage   63.81%   63.95%   +0.13%     
==========================================
  Files          40       40              
  Lines        2222     2222              
==========================================
+ Hits         1418     1421       +3     
+ Misses        682      680       -2     
+ Partials      122      121       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JeyJeyGao JeyJeyGao changed the title fix: E2E test cases for OCI layout fix(test): E2E test cases for OCI layout May 26, 2023
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that testdata are still in oci artifact manifest type. We'd better update them to oci image manifest? Otherwise, LGTM.

@JeyJeyGao
Copy link
Contributor Author

I notice that testdata are still in oci artifact manifest type. We'd better update them to oci image manifest? Otherwise, LGTM.

This PR is for fixing oci layout. #668 will be done in another PR.

Two-Hearts
Two-Hearts previously approved these changes May 30, 2023
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes May 31, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi previously approved these changes Jun 2, 2023
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

test/e2e/suite/command/list.go Outdated Show resolved Hide resolved
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit e090aa9 into notaryproject:main Jun 5, 2023
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCI layout E2E test cases issue
5 participants