docs: update RELEASE_CHECKLIST.md #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feynman Zhou <[email protected]>
FeynmanZhou
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
SteveLasker and
Two-Hearts
as code owners
shizhMSFT
reviewed
Jun 9, 2023
priteshbandi
reviewed
Jun 9, 2023
Signed-off-by: Feynman Zhou <[email protected]>
Two-Hearts
reviewed
Jun 15, 2023
Signed-off-by: Feynman Zhou <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
==========================================
+ Coverage 63.77% 71.34% +7.56%
==========================================
Files 40 45 +5
Lines 2228 2174 -54
==========================================
+ Hits 1421 1551 +130
+ Misses 686 429 -257
- Partials 121 194 +73 ☔ View full report in Codecov by Sentry. |
Two-Hearts
reviewed
Jun 19, 2023
Signed-off-by: Feynman Zhou <[email protected]>
shizhMSFT
reviewed
Jun 26, 2023
shizhMSFT
reviewed
Jul 21, 2023
Signed-off-by: Feynman Zhou <[email protected]>
|
LGTM but IAMNAM |
shizhMSFT
reviewed
Aug 15, 2023
shizhMSFT
reviewed
Aug 15, 2023
shizhMSFT
changed the title
Signed-off-by: Feynman Zhou <[email protected]>
FeynmanZhou
dismissed stale reviews from shizhMSFT and Two-Hearts
via
c569b95
Two-Hearts
reviewed
Jan 25, 2024
|
This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days. |
Two-Hearts
reviewed
Jun 4, 2024
Include Patrick's comment Co-authored-by: Patrick Zheng <[email protected]> Signed-off-by: Feynman Zhou <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update RELEASE_CHECKLIST.md per suggestions from Notary Project community meeting and notaryproject/.github#28. Please note that this PR focuses on updating the Notation CLI release process only.
I will create another PR to add the release checklist for releasing a patch.