Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): update testdata OCI layout images #727

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Jun 27, 2023

Update:

  • update testdata OCI layout images from OCI Artifact to OCI Image format
  • update ginkgo version

Fix:

Resolves #726
Signed-off-by: Junjie Gao [email protected]

@JeyJeyGao JeyJeyGao marked this pull request as ready for review June 27, 2023 06:25
@JeyJeyGao JeyJeyGao changed the title fix(e2e): update testdata oci layout images fix(e2e): update testdata OCI layout images Jun 27, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #727 (499f47b) into main (0f3c4ae) will increase coverage by 17.06%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##             main     #727       +/-   ##
===========================================
+ Coverage   46.59%   63.66%   +17.06%     
===========================================
  Files          40       40               
  Lines        2232     2232               
===========================================
+ Hits         1040     1421      +381     
+ Misses       1105      690      -415     
- Partials       87      121       +34     

see 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 77eb77a into notaryproject:main Jun 30, 2023
4 checks passed
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E test failed but still passed CI
5 participants