-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: spec updates for arbitrary blob signing #811
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
==========================================
+ Coverage 64.93% 67.35% +2.42%
==========================================
Files 45 45
Lines 2729 2166 -563
==========================================
- Hits 1772 1459 -313
+ Misses 795 545 -250
Partials 162 162 ☔ View full report in Codecov by Sentry. |
Before diving into the detailed UX design, shall we have a PR in the https://github.com/notaryproject/specifications repo to add the new specs related to blob? For example, signature payload, trust policy, ect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rgnote I left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rgnote. I left additional comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit, but I am not a maintainer of notation
repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some note, for help of top level sign, verify, inspect and list that they only applies to oci.
They were already updated to note that they work with OCI artifacts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this pull request, and we can address the following comments in the next PR:
- Support 'blob sign' and 'verify' commands to function with standard input and output?
- In my opinion, merely mentioning 'oci' in the command description (or in help) isn't sufficient; it should be more prominent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor comments.
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Rakesh Gariganti <[email protected]> Signed-off-by: rgnote <[email protected]>
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Rakesh Gariganti <[email protected]> Signed-off-by: rgnote <[email protected]>
Signed-off-by: rgnote <[email protected]>
Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: rgnote <[email protected]>
…project#872) Signed-off-by: rgnote <[email protected]>
Signed-off-by: rgnote <[email protected]>
…roject#874) Signed-off-by: rgnote <[email protected]>
…otaryproject#875) Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: rgnote <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: rgnote <[email protected]>
…project#878) Signed-off-by: rgnote <[email protected]>
…roject#879) Signed-off-by: rgnote <[email protected]>
…roject#877) Signed-off-by: rgnote <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: rgnote <[email protected]>
…roject#883) Signed-off-by: rgnote <[email protected]>
…roject#884) Signed-off-by: rgnote <[email protected]>
…ect#886) Signed-off-by: rgnote <[email protected]>
…project#887) Signed-off-by: rgnote <[email protected]>
…roject#896) Signed-off-by: rgnote <[email protected]>
…roject#895) Signed-off-by: rgnote <[email protected]>
… to 1.1.0 (notaryproject#891) Signed-off-by: rgnote <[email protected]>
Signed-off-by: rgnote <[email protected]>
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Rakesh Gariganti <[email protected]> Signed-off-by: rgnote <[email protected]>
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Rakesh Gariganti <[email protected]> Signed-off-by: rgnote <[email protected]>
…roject#898) Signed-off-by: rgnote <[email protected]>
Signed-off-by: rgnote <[email protected]>
…roject#901) Signed-off-by: rgnote <[email protected]>
CLI Spec updated for Arbitrary blob signing. Proposal https://hackmd.io/ewbJr2ZnT4a8U1ObDVXcSw?view#CLI-Spec and https://hackmd.io/@-KPyDkW6QfGA-pldFa13pA/ByuHffALa
Signing Scheme and trust policy updates : notaryproject/specifications#283
Signed-off-by: rgnote [email protected]