docs: spec updates for arbitrary blob signing #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgnote
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
priteshbandi,
shizhMSFT,
SteveLasker and
Two-Hearts
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
==========================================
+ Coverage 64.93% 67.35% +2.42%
==========================================
Files 45 45
Lines 2729 2166 -563
==========================================
- Hits 1772 1459 -313
+ Misses 795 545 -250
Partials 162 162 ☔ View full report in Codecov by Sentry. |
shizhMSFT
changed the title
shizhMSFT
changed the title
JeyJeyGao
reviewed
Oct 30, 2023
|
Before diving into the detailed UX design, shall we have a PR in the https://github.com/notaryproject/specifications repo to add the new specs related to blob? For example, signature payload, trust policy, ect. |
shizhMSFT
reviewed
Oct 30, 2023
Two-Hearts
reviewed
Oct 30, 2023
Two-Hearts
reviewed
Nov 2, 2023
shizhMSFT
reviewed
Nov 6, 2023
Two-Hearts
reviewed
Nov 14, 2023
yizha1
reviewed
Nov 15, 2023
They were already updated to note that they work with OCI artifacts. |
priteshbandi
previously approved these changes
Nov 18, 2023
There was a problem hiding this comment.
Approving this pull request, and we can address the following comments in the next PR:
- Support 'blob sign' and 'verify' commands to function with standard input and output?
- In my opinion, merely mentioning 'oci' in the command description (or in help) isn't sufficient; it should be more prominent
yizha1
reviewed
Nov 22, 2023
yizha1
reviewed
Nov 22, 2023
Two-Hearts
reviewed
Nov 27, 2023
shizhMSFT
reviewed
Dec 7, 2023
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Rakesh Gariganti <[email protected]> Signed-off-by: rgnote <[email protected]>
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Rakesh Gariganti <[email protected]> Signed-off-by: rgnote <[email protected]>
Signed-off-by: rgnote <[email protected]>
Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: rgnote <[email protected]>
…project#872) Signed-off-by: rgnote <[email protected]>
Signed-off-by: rgnote <[email protected]>
…roject#874) Signed-off-by: rgnote <[email protected]>
…otaryproject#875) Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: rgnote <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: rgnote <[email protected]>
…project#878) Signed-off-by: rgnote <[email protected]>
…roject#879) Signed-off-by: rgnote <[email protected]>
…roject#877) Signed-off-by: rgnote <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: rgnote <[email protected]>
…roject#883) Signed-off-by: rgnote <[email protected]>
…roject#884) Signed-off-by: rgnote <[email protected]>
…ect#886) Signed-off-by: rgnote <[email protected]>
…project#887) Signed-off-by: rgnote <[email protected]>
…roject#896) Signed-off-by: rgnote <[email protected]>
…roject#895) Signed-off-by: rgnote <[email protected]>
… to 1.1.0 (notaryproject#891) Signed-off-by: rgnote <[email protected]>
Signed-off-by: rgnote <[email protected]>
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Rakesh Gariganti <[email protected]> Signed-off-by: rgnote <[email protected]>
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Rakesh Gariganti <[email protected]> Signed-off-by: rgnote <[email protected]>
…roject#898) Signed-off-by: rgnote <[email protected]>
Signed-off-by: rgnote <[email protected]>
…roject#901) Signed-off-by: rgnote <[email protected]>
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI Spec updated for Arbitrary blob signing. Proposal https://hackmd.io/ewbJr2ZnT4a8U1ObDVXcSw?view#CLI-Spec and https://hackmd.io/@-KPyDkW6QfGA-pldFa13pA/ByuHffALa
Signing Scheme and trust policy updates : notaryproject/specifications#283
Signed-off-by: rgnote [email protected]