Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update references with the tag version #836

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Nov 23, 2023

Resolve #456

Signed-off-by: Yi Zha [email protected]

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4569f3f) 64.05% compared to head (2d1a963) 64.05%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #836   +/-   ##
=======================================
  Coverage   64.05%   64.05%           
=======================================
  Files          40       40           
  Lines        2323     2323           
=======================================
  Hits         1488     1488           
  Misses        709      709           
  Partials      126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 merged commit 3574c95 into notaryproject:main Dec 7, 2023
5 checks passed
@yizha1 yizha1 deleted the fix_version branch December 7, 2023 23:52
Two-Hearts pushed a commit to Two-Hearts/notation that referenced this pull request Dec 14, 2023
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use tagged version for references.
6 participants