fix: notation plugin install error messages and tests
#855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT and
SteveLasker
as code owners
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
==========================================
+ Coverage 63.91% 65.14% +1.23%
==========================================
Files 45 45
Lines 2699 2717 +18
==========================================
+ Hits 1725 1770 +45
+ Misses 820 787 -33
- Partials 154 160 +6 ☔ View full report in Codecov by Sentry. |
Two-Hearts
changed the title
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
changed the title
Two-Hearts
changed the title
notation plugin install error messages
shizhMSFT
reviewed
Dec 28, 2023
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
priteshbandi
reviewed
Jan 2, 2024
priteshbandi
reviewed
Jan 2, 2024
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
changed the title
notation plugin install error messagesnotation plugin install error messages and tests
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
reviewed
Jan 3, 2024
shizhMSFT
reviewed
Jan 3, 2024
Signed-off-by: Patrick Zheng <[email protected]>
6 tasks
rgnote
pushed a commit
to rgnote/notation
that referenced
this pull request
Mar 8, 2024
…t#855) * This PR improves error messages of `notation plugin install` command and updates the related cli specs. (Resolves notaryproject#853) * This PR also adds zip bomb and zip slip tests. Signed-off-by: Patrick Zheng <[email protected]>
rgnote
pushed a commit
to rgnote/notation
that referenced
this pull request
Mar 8, 2024
…t#855) * This PR improves error messages of `notation plugin install` command and updates the related cli specs. (Resolves notaryproject#853) * This PR also adds zip bomb and zip slip tests. Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: rgnote <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves error messages of
notation plugin installcommand and updates the related cli specs as well.This PR also adds zip bomb and zip slip tests.
Resolves #853.