Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: bump up notation-go v1.1.1 and other dependencies #952

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

JeyJeyGao
Copy link
Contributor

Signed-off-by: Junjie Gao [email protected]

@JeyJeyGao JeyJeyGao changed the title bump: bump up notation-go v1.1.1 bump: bump up notation-go v1.1.1 and other dependencies Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.34%. Comparing base (b6dca32) to head (b3ad7e5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #952   +/-   ##
=======================================
  Coverage   71.34%   71.34%           
=======================================
  Files          45       45           
  Lines        2174     2174           
=======================================
  Hits         1551     1551           
  Misses        429      429           
  Partials      194      194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shizhMSFT
shizhMSFT previously approved these changes Jun 3, 2024
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the dependencies in test/e2e. They are test/e2e/go.mod and test/e2e/plugin/go.mod.

priteshbandi
priteshbandi previously approved these changes Jun 3, 2024
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao
Copy link
Contributor Author

We should also update the dependencies in test/e2e. They are test/e2e/go.mod and test/e2e/plugin/go.mod.

Updated.

@Two-Hearts
Copy link
Contributor

LGTM, but waiting for the DCO status.

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao closed this Jun 5, 2024
@JeyJeyGao JeyJeyGao reopened this Jun 5, 2024
@JeyJeyGao JeyJeyGao closed this Jun 5, 2024
@JeyJeyGao JeyJeyGao reopened this Jun 5, 2024
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao merged commit 6e89dd7 into notaryproject:main Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants