Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Android create banana split #2362

Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

feat: Android create banana split #2362

wants to merge 59 commits into from

Conversation

Dmitry-Borodin
Copy link
Contributor

@Dmitry-Borodin Dmitry-Borodin commented Mar 6, 2024 •
edited
Loading

Purpose

Flow to create banana split

Scope

  • new screens to create banana split on the phone
  • restore keyset - icon to open camera to restore from BS

This feature is implemented, would be nice to do some external testing before merging.
Menu to create BS in release build is disabled via feature flag.

Screenshots

Left title, i.e. "Before" Right title, i.e. "After"
image image
image image
image image

@Dmitry-Borodin
started work with create bs
6371708
@Dmitry-Borodin
create bs progress
298d92e
@Dmitry-Borodin
restore flow camera icon work in progress
6c7e7a5
@Dmitry-Borodin
migrated flow row from depricated library to core compose. Added scan…
b925961 
… icon into entry box
@Dmitry-Borodin
implementing create BS layout
fdb40d5
@Dmitry-Borodin
make numbers only keyboard
fd585b9
@Dmitry-Borodin
create bs layout work in progress
efe61d2
@Dmitry-Borodin
create bs layout work in progress 2
a993588
@Dmitry-Borodin
create bs layout work in progress 2
10d8b2e
@Dmitry-Borodin
banana split logic work started
ea62f25
@Dmitry-Borodin
finilizing layout create BS
04e266b
@Dmitry-Borodin
Merge branch 'master' of github.com:paritytech/parity-signer into and…
10f0683 
…roid-banana-split-create
@Dmitry-Borodin
working with BS export menu
b8fef34
@Dmitry-Borodin
export banana split passphrase manu added and bottom sheet clarificat…
e1a0ee5 
…ions
@Dmitry-Borodin
ba menu strings
d0241aa
@Dmitry-Borodin
иы скуфеуbs create flow work in progress
869e6d1
@Dmitry-Borodin
fixing create bs layout
a58d2d8
@Dmitry-Borodin
bs_show_screens
c35efb8
@Dmitry-Borodin
banana split export screens gluing together
80a8197
@Dmitry-Borodin
Merge branch 'master' of github.com:paritytech/parity-signer into and…
13107fc 
…roid-banana-split-create
@Dmitry-Borodin
passing arguments for create bs
d374f96
@Dmitry-Borodin
working with BS repository
bdbe8d6
@Dmitry-Borodin
working on banana split
c1b7b1d
@Dmitry-Borodin
Merge branch 'master' of github.com:paritytech/parity-signer into and…
3efd536 
…roid-banana-split-create
@Dmitry-Borodin
work in progress create bs
1253378
@Dmitry-Borodin
Merge branch 'master' of github.com:paritytech/parity-signer into and…
47d7745 
…roid-banana-split-create
@Dmitry-Borodin
work in progress create bs 2
53e21a1
@Dmitry-Borodin
integrating clean encrzpted storage into bs flow
5805be1
@Dmitry-Borodin
implemented crypto storage for non auth data
916092c
@Dmitry-Borodin
created test siute for qr codes storage
8654863
Dmitry-Borodin and others added 14 commits March 6, 2024 20:38
@Dmitry-Borodin Dmitry-Borodin marked this pull request as ready for review March 15, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krodak krodak krodak approved these changes

Assignees
No one assigned
Labels
android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dmitry-Borodin @krodak