ModuleNotFoundError when installing package from github #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
django
insetup.py
to grab the version string blows up when installing this package from github anddjango
isn't installed yet.Steps to reproduce
Result:
The fix
It's likely not the right way to do it but I moved the version string from
hashid_field/__init__.py
tosetup.py
so thatdjango
is no longer needed just to get the version. If there's a correct way of fixing this just point me in the right direction.Installing from the "fixed" branch succeeds:
pip install -r fixed_requirements.txt