Include internal hashid state into the picking state #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My apologies, I'm converting it back to draft to ensure that this change works correctly |
Python gives it more priority instead of __getstate__/__setstate__ methods
|
Just a note that I haven't missed or forgotten this, just haven't had time to do a deep dive into what's going on with django-cacheops. However, pickling the _hashids object (which is an instance of the Hashids library object) doesn't have the right smell. But I could be wrong. Won't know until I have some time to dedicated to this. Hopefully soon. |
|
I have merged this in, and tested the behavior of unpickling old pickled objects, and it looks like it's fully backwards compatible. So unpickling should no longer need to recompute the hashid. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit the same issue as in #55 with
django-cacheopsanddjango-hashid-field.Unfortunately for me, that
enable_hashid_object=False"workaround" can't be applied in my case, but I've found that if you includeself._hashidsattribute into the pickled state, hashid objects can be successfully deserialized from the cache provided bydjango-cacheops.As a side thought: the actual fix might be that some other attribute is now excluded from the pickled representation, but I'm not exactly sure what else can affect this behavior in here.
Please note that this is a breaking change as it changes pickling behavior.