planner: Fix 'nOf' prereq check with module code wildcards #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Wxy2003-xy is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3758 +/- ##
==========================================
+ Coverage 53.87% 54.85% +0.97%
==========================================
Files 274 274
Lines 6032 6049 +17
Branches 1449 1446 -3
==========================================
+ Hits 3250 3318 +68
+ Misses 2782 2731 -51 ☔ View full report in Codecov by Sentry. |
zwliew
changed the title
zwliew
changed the title
zwliew
force-pushed
the
wxy/prereq-logic-patch
branch
from
cf50cb1
to
4a5ccad
Compare
zwliew
changed the title
zwliew
approved these changes
Aug 17, 2024
|
Thank you. I refactored the code a bit to reduce code duplication and fixed an annoying disambiguity when displaying conflict texts involving multiple 'or', 'and', and 'nOf' fragments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#3740 prerequisite check logic for nOf wildcard case not working as intended
Separately, we now also disambiguate conflict texts involving 'and', 'or', and 'nOf' prereq fragments.
Implementation
handle wildcard case in nOf cases separately from normal course code
Other Information