Skip to content

Commit

Permalink
Remove possesive form of inanimate objects
Browse files Browse the repository at this point in the history
  • Loading branch information
dagardner-nv committed Jul 26, 2024
1 parent c8416b9 commit 24cda33
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 11 deletions.
5 changes: 0 additions & 5 deletions ci/vale/styles/config/vocabularies/morpheus/accept.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ CPython
Dask
Databricks

# Allow for the possesive form (ex debugger's source path)
debugger's
[Dd]eserialize
Dev
[Dd]ocstring(s?)
Expand All @@ -34,7 +32,6 @@ GPU(s?)
Grafana
[Gg]ranularities
[Hh]ashable
[Hh]ostname(s?)
[Ii]nferencing

# libcudf isn't styled in the way that cuDF is https://docs.rapids.ai/api/libcudf/stable/
Expand All @@ -45,8 +42,6 @@ Milvus
MLflow
Morpheus

# Allow for possessive form ex: "... using MRC's PythonNode class"
MRC's
[Nn]amespace(s?)
NeMo
NIC
Expand Down
3 changes: 1 addition & 2 deletions docs/source/developer_guide/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@ This workflow utilizes a Docker container to set up most dependencies ensuring a
```shell
DOCKER_TARGET=development_pydbg ./docker/build_container_dev.sh
```
1. Note: When debugging Python code, you just need to add `ci/conda/recipes/python-dbg/source` to your debugger's
source path.
1. Note: When debugging Python code, you just need to add `ci/conda/recipes/python-dbg/source` to the source path your debugger.
1. Once created, you will be able to introspect Python objects from within GDB. For example, if we were to break within a generator setup call and examine its `PyFrame_Object` `f`, it might be similar to:
```shell
#4 0x000056498ce685f4 in gen_send_ex (gen=0x7f3ecc07ad40, arg=<optimized out>, exc=<optimized out>, closing=<optimized out>) at Objects/genobject.c:222
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ Finally, the `_build_single` method will be used at stage build time to construc
return node
```

For our purposes, a Morpheus _stage_ defines the input data type the stage will accept, the unit of work to be performed on that data, and the output data type. In contrast each individual node or nodes comprising a _stage_'s unit of work are wired into the underlying MRC execution pipeline. To build the node, we will call the `make_node` method of the builder instance, passing it our `unique_name` property method and applying MRC's map operator to the `on_data` method. We used the `unique_name` property, which will take the `name` property which we already defined and append a unique id to it.
For our purposes, a Morpheus _stage_ defines the input data type the stage will accept, the unit of work to be performed on that data, and the output data type. In contrast each individual node or nodes comprising a _stage_'s unit of work are wired into the underlying MRC execution pipeline. To build the node, we will call the `make_node` method of the builder instance, passing it our `unique_name` property method and applying the map operator to the `on_data` method. We used the `unique_name` property, which will take the `name` property which we already defined and append a unique id to it.
```python
node = builder.make_node(self.unique_name, ops.map(self.on_data))
```
Expand Down
4 changes: 2 additions & 2 deletions docs/source/developer_guide/guides/3_simple_cpp_stage.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,14 @@ C++ message object declarations can be found in the header files that are locate
#include <morpheus/messages/meta.hpp>
```

Morpheus C++ source stages inherit from MRC's `PythonSource` class:
Morpheus C++ source stages inherit from the `PythonSource` class from MRC:

```cpp
template <typename OutputT, typename ContextT = mrc::runnable::Context>
class PythonSource : ...
```
The `OutputT` type will be the datatype emitted by this stage. In contrast, general stages and sinks must inherit from MRC's `PythonNode` class, which specifies both receive and emit types:
The `OutputT` type will be the datatype emitted by this stage. In contrast, general stages and sinks must inherit from the `PythonNode` class from MRC, which specifies both receive and emit types:
```cpp
template <typename InputT, typename OutputT, typename ContextT = mrc::runnable::Context>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Adding a new source for the DFP pipeline requires defining five critical pieces:
* A username or full name (for example, `"johndoe"` or `"Jane Doe"`)
* User's LDAP ID number
* A user group (for example, `"sales"` or `"engineering"`)
* Hostname of a machine on the network
* Host name of a machine on the network
* IP address of a client
* Name of a service (for example, `"DNS"`, `"Customer DB"`, or `"SMTP"`)

Expand Down

0 comments on commit 24cda33

Please sign in to comment.