Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less intrusive doc builds #1060

Merged
merged 24 commits into from
Aug 23, 2023
Merged

Less intrusive doc builds #1060

merged 24 commits into from
Aug 23, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jul 17, 2023 •
edited
Loading

Description

  • Remove imports from morpheus/utils/nvt/__init__.py
  • Move annotate hack to decorators.py

fixes #1055

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv
Rather than mocking pandas, intercept parsing of EncoderDataFrame and…
d5fd824 
… disable the inherited-members option only for this one class
@dagardner-nv
Remove import of MutateOp, allowing the register_morpheus_extensions …
f496bda 
…method to be mocked prior to any merlin or nvtabular modules are imported
@dagardner-nv
Update import path for MutateOp
87aa76f
@dagardner-nv
Don't import register_morpheus_extensions and patch_numpy_dtype_regis…
b2dca87 
…try directly, allowing them to be mocked, remove check of MORPHEUS_IN_SPHINX_BUILD env var
@dagardner-nv
Mock register_morpheus_extensions and patch_numpy_dtype_registry to p…
c2d9db5 
…revent side-effects during documentation builds
@dagardner-nv
Perform inspect.unwrap in a try block since auto-doc mocks will retur…
e7c896e 
…n themselves when unwrapping, causing inspect.unwrap to raise a cycle error
@dagardner-nv
Remove hacky work-around
1ffb42b
@dagardner-nv
Remove un-needed mock
402145d
@dagardner-nv
Hack to remove mocked transform method
b8f8625
@dagardner-nv dagardner-nv requested a review from a team as a code owner July 17, 2023 20:37
@dagardner-nv dagardner-nv added non-breaking Non-breaking change doc Improvements or additions to documentation 3 - Ready for Review labels Jul 17, 2023
@dagardner-nv dagardner-nv requested a review from a team as a code owner July 21, 2023 16:56
@dagardner-nv dagardner-nv self-assigned this Jul 28, 2023
mdemoret-nv
mdemoret-nv requested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree with some of these changes. By making it "less intrusive" we have separated the workaround from the source code making it harder to maintain in the future.

docs/source/conf.py Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
@dagardner-nv dagardner-nv reopened this Aug 22, 2023
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 09395b5 into nv-morpheus:branch-23.11 Aug 23, 2023
6 checks passed
@dagardner-nv dagardner-nv deleted the david-doc-builds-nvt-mock branch August 23, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Investigate possibility of performing nvt mocks in conf.py
2 participants
@dagardner-nv @mdemoret-nv