Fixing linting errors which could not be resolved in 23.07 #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
added
non-breaking
…dd_fix-23.07-linting-david
Fix older test
…ed multiple context expressions in a single with statement. In version 0.40 the parser was replaced which fixed this issue. Currently the latest version of yapf on conda-forge is 0.33, switching to pip to adopt this version.
Updates from David
|
This may eventually need yapf 0.40 which is not yet available: conda-forge/yapf-feedstock#39 |
3 tasks
dagardner-nv
approved these changes
Aug 22, 2023
|
/merge |
tzemicheal
approved these changes
Aug 23, 2023
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were too many linting errors to fix in 23.07 burndown so a PR has been created to fix this in 23.11.
Closes #1050