Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gitutils.py by using the Github CLI when available #1088

Merged
merged 12 commits into from
Aug 17, 2023

Conversation

mdemoret-nv
Copy link
Contributor

Description

The gitutils.py script often fails when you are working in a PR, or if there has been a commit to your target branch since you created your current branch.

This improves the utility by using the Github CLI to query the PR information when possible and get the true target branch for the current PR.

If the Github CLI is not available, or the branch isnt in a PR, it falls back to the previous functionality.

@mdemoret-nv mdemoret-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Jul 21, 2023
@mdemoret-nv mdemoret-nv requested review from a team as code owners July 21, 2023 20:33
@mdemoret-nv mdemoret-nv removed the request for review from a team August 17, 2023 19:54
@mdemoret-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit aba421e into nv-morpheus:branch-23.11 Aug 17, 2023
6 checks passed
@mdemoret-nv mdemoret-nv deleted the mdd_fix-gitutils branch August 18, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants