Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tests to force .pyi files to be committed into the repo #1111

Merged

Conversation

mdemoret-nv
Copy link
Contributor

Description

This PR changes the stub generation to be committed into the repo instead of as part of the build. This will allow CI steps that need the PYI files to not require a GPU as well.

This works by always copying the PYI files back to the source tree so they will show up as diffs. Any diffs during the test phase will be reported as an error.

Closes #766

@mdemoret-nv mdemoret-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Jul 28, 2023
@mdemoret-nv mdemoret-nv requested review from a team as code owners July 28, 2023 21:24
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you verified that the tests can fail due to mismatched .pyi files?

ci/release/update-version.sh Show resolved Hide resolved
morpheus.code-workspace Show resolved Hide resolved
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 662cd40 into nv-morpheus:branch-23.11 Aug 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Avoid running stubgen in CI
3 participants