Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a --viz_direction flag to CLI #1119

Merged
merged 7 commits into from
Aug 17, 2023
Merged

Add a --viz_direction flag to CLI #1119

merged 7 commits into from
Aug 17, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Aug 3, 2023 •
edited
Loading

Description

fixes #643

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner August 3, 2023 20:21
@dagardner-nv dagardner-nv changed the title David rankdir 643 Add a --viz_direction flag to CLI Aug 3, 2023
@dagardner-nv dagardner-nv added non-breaking Non-breaking change feature request New feature or request 3 - Ready for Review labels Aug 3, 2023
cwharris
cwharris approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming you've manually confirmed the viz output to correspond to the given rank choices, since we don't have the infrastructure to check for that automatically.

tests/test_pipe_viz.py Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 43dfcc5 into nv-morpheus:branch-23.11 Aug 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Make graphviz rankdir configurable
3 participants
@dagardner-nv @mdemoret-nv @cwharris