Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasks and metadata properties to python ControlMessage #1134

Merged
merged 13 commits into from
Aug 23, 2023

Conversation

cwharris
Copy link
Contributor

Adding tasks and metadata properties to python ControlMessage, allowing for easier debugging of control messages.

Closes #1131

@cwharris cwharris added non-breaking Non-breaking change improvement Improvement to existing functionality labels Aug 18, 2023
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 changes

morpheus/_lib/include/morpheus/messages/control.hpp Outdated Show resolved Hide resolved
morpheus/_lib/include/morpheus/messages/control.hpp Outdated Show resolved Hide resolved
@cwharris cwharris marked this pull request as ready for review August 23, 2023 17:28
@cwharris cwharris requested a review from a team as a code owner August 23, 2023 17:28
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion to help with typing

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 8e21076 into nv-morpheus:branch-23.11 Aug 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Add tasks and metadata readonly properties to ControlMessage
2 participants