Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command line examples for module-based DFP pipelines #1154

Merged
merged 16 commits into from
Sep 1, 2023
Merged

Command line examples for module-based DFP pipelines #1154

merged 16 commits into from
Sep 1, 2023

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Aug 24, 2023 •
edited
Loading

Description

  • Update docs to include command line examples of running module-based DFP pipelines (training, inference, training+inference)
  • Move control messages to centralized location for use with running examples and benchmarks

Closes #1147
Fixes #1151
Fixes #1153

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

@efajardo-nv efajardo-nv added non-breaking Non-breaking change doc Improvements or additions to documentation labels Aug 24, 2023
@efajardo-nv efajardo-nv marked this pull request as ready for review August 25, 2023 14:28
@efajardo-nv efajardo-nv requested a review from a team as a code owner August 25, 2023 14:28
@efajardo-nv efajardo-nv self-assigned this Aug 25, 2023
mdemoret-nv
mdemoret-nv approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Lets rename the dfp_modules_batch_pipeline.py to something that has "train", "infer" and "batch" in the name and removes "modules"

examples/digital_fingerprinting/production/morpheus/dfp/utils/dfp_arg_parser.py Outdated Show resolved Hide resolved
examples/digital_fingerprinting/production/morpheus/dfp/utils/dfp_arg_parser.py Outdated Show resolved Hide resolved
examples/digital_fingerprinting/production/morpheus/benchmarks/conftest.py Show resolved Hide resolved
docs/source/developer_guide/guides/10_modular_pipeline_digital_fingerprinting.md Outdated Show resolved Hide resolved
@efajardo-nv efajardo-nv mentioned this pull request Aug 29, 2023
Closed
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 29, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@efajardo-nv
Copy link
Contributor Author

/ok to test

@efajardo-nv
Copy link
Contributor Author

/ok to test

@efajardo-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 485c983 into nv-morpheus:branch-23.11 Sep 1, 2023
6 checks passed
@efajardo-nv efajardo-nv deleted the dfp-module-pipeline-examples branch July 29, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@efajardo-nv efajardo-nv

Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
2 participants
@efajardo-nv @mdemoret-nv