Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope Zookeeper & Kafka fixtures to session #1160

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Scope Zookeeper & Kafka fixtures to session #1160

merged 7 commits into from
Aug 30, 2023

Conversation

dagardner-nv
Copy link
Contributor

Description

  • pytest --run_slow --fail_missing --run_kafka 2 minutes faster
  • kafka_consumer & kafka_topics fixtures are still function scoped, ensuring each test will receive unique topics & client
  • Move Kafka related testing code to tests/_utils/kafka.py

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv
Move Kafka related stuff to its own module, make zookeeper and kafka_…
2bd239f 
…server fixtures per-session, always use a unique topic, group.id and client.id
@dagardner-nv
Cleanups, checks passing
5473220
@dagardner-nv dagardner-nv requested a review from a team as a code owner August 29, 2023 17:41
@dagardner-nv dagardner-nv self-assigned this Aug 29, 2023
@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality 3 - Ready for Review labels Aug 29, 2023
@dagardner-nv
Copy link
Contributor Author

/ok to test

cwharris
cwharris approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for consolidating all of the kafka utils to the appropriate file. 🙏

tests/_utils/kafka.py Show resolved Hide resolved
tests/_utils/kafka.py Show resolved Hide resolved
tests/_utils/kafka.py Outdated Show resolved Hide resolved
tests/_utils/kafka.py Outdated Show resolved Hide resolved
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b56703f into nv-morpheus:branch-23.11 Aug 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dagardner-nv @cwharris @mdemoret-nv