Update Downloader utility class to use static dask cluster #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
requested changes
Aug 30, 2023
…into file-to-df-loader-fix
…v/Morpheus into file-to-df-loader-fix
efajardo-nv
changed the title
file_to_df_loader to use static downloader…into file-to-df-loader-fix
mdemoret-nv
requested changes
Sep 13, 2023
mdemoret-nv
approved these changes
Sep 21, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
file_to_df_loaderis creating a new downloader object for every file list batch. Each downloader creates its own dask cluster which results in very slow processing and DFP module pipelines eventually fail.Fixes #1146
Checklist
[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.