Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phishing example fix #1215

Merged
merged 6 commits into from
Sep 25, 2023

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Sep 21, 2023

Description

  • Update labels file to reflect actual model outputs: not_phishing and is_phishing
  • Add AddScores stage to Python and CLI examples
  • Remove FilterDetectionsStage because model output contains probabilities for both not_phishing and is_phishingone of which will always exceed threshold. This results in nothing ever being filtered out.

Closes #1208

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added non-breaking Non-breaking change doc Improvements or additions to documentation labels Sep 21, 2023
@efajardo-nv efajardo-nv self-assigned this Sep 21, 2023
@efajardo-nv efajardo-nv requested review from a team as code owners September 21, 2023 20:12
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 11697de into nv-morpheus:branch-23.11 Sep 25, 2023
7 checks passed
@mdemoret-nv mdemoret-nv deleted the phishing-example-fix branch September 25, 2023 16:22
dagardner-nv added a commit to dagardner-nv/Morpheus that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[DOC]: What is the labels file for in 2_real_world_phishing?
2 participants