Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer documentation to reflect new compute_schema changes #1341

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Nov 6, 2023

Description

  • Update developer documentation to reflect new compute_schema changes.
  • Cherry-pick --run_milvus flag from fea-sherlock (unrelated I just needed to quickly run the rest of the tests)
  • Fix long-standing bug in examples/developer_guide/3_simple_cpp_stage/pass_thru.py, where the Python impl can support messages of any type, but the C++ impl only supports MultiMessage
  • Copy code snippets from docs/source/developer_guide/guides/7_python_modules.md into examples/developer_guide/7_python_modules/ allowing them to be tested & validated. Add a simple end-to-end test for the modules & stages (part of [DOC]: Add code for module developer guides to examples/developer_guide #993)
  • Update the compound module snippet to operate on MessageMeta rather than int making it easier to run in a Morpheus pipeline.

Closes #1252

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added non-breaking Non-breaking change doc Improvements or additions to documentation labels Nov 6, 2023
@dagardner-nv dagardner-nv self-assigned this Nov 6, 2023
@dagardner-nv dagardner-nv requested review from a team as code owners November 6, 2023 16:38
@dagardner-nv dagardner-nv marked this pull request as draft November 6, 2023 16:39
@dagardner-nv dagardner-nv marked this pull request as ready for review November 7, 2023 23:26
@dagardner-nv dagardner-nv added this to the 23.11 - MNMG milestone Nov 8, 2023
@dagardner-nv dagardner-nv changed the title Draft: 23.11 Documentation updates Update developer documentation to reflect new compute_schema changes Nov 22, 2023
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d5665ba into nv-morpheus:branch-23.11 Nov 22, 2023
6 checks passed
@dagardner-nv dagardner-nv deleted the david-23.11-docs-1252 branch November 22, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[DOC]: Document new StageSchema class and compute_schema changes
2 participants