Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLM C++ test and doc updates #1379

Merged
merged 4 commits into from
Nov 23, 2023
Merged

LLM C++ test and doc updates #1379

merged 4 commits into from
Nov 23, 2023

Conversation

efajardo-nv
Copy link
Contributor

Description

  • C++ unit test updates
  • Split some tests into multiple tests
  • Minor doc updates and fixes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added improvement Improvement to existing functionality sherlock Issues/PRs related to Sherlock workflows and components labels Nov 21, 2023
@efajardo-nv efajardo-nv added this to the 23.11 - Sherlock milestone Nov 21, 2023
@efajardo-nv efajardo-nv self-assigned this Nov 21, 2023
@efajardo-nv efajardo-nv requested a review from a team as a code owner November 21, 2023 21:25
@efajardo-nv efajardo-nv added the non-breaking Non-breaking change label Nov 21, 2023
mdemoret-nv
mdemoret-nv approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mdemoret-nv mdemoret-nv changed the base branch from fea-sherlock to branch-23.11 November 22, 2023 22:58
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit f87f16c into nv-morpheus:branch-23.11 Nov 23, 2023
6 checks passed
@mdemoret-nv mdemoret-nv deleted the llm-cpp-test-doc-updates branch November 23, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@efajardo-nv efajardo-nv

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Archived in project
Milestone
23.11 - Sherlock
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@efajardo-nv @mdemoret-nv