Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_vdb_upload_pipe #1381

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix test_vdb_upload_pipe #1381

merged 2 commits into from
Nov 22, 2023

Conversation

dagardner-nv
Copy link
Contributor

Description

  • Update mocks to reflect that When caching is disabled web-scraper uses requests not requests_cache.
  • Revert accidental change to tests/tests_data/service/milvus_rss_data.json during merge conflicts

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner November 22, 2023 18:19
@dagardner-nv dagardner-nv self-assigned this Nov 22, 2023
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components labels Nov 22, 2023
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c4f2b56 into nv-morpheus:branch-23.11 Nov 22, 2023
10 checks passed
@dagardner-nv dagardner-nv deleted the david-vdb_upload_pipe-test branch November 22, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dagardner-nv @mdemoret-nv