Improve camouflage startup issues #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve camouflage error reporting by redirecting stdout and stderr to a file. This is a work-around for not being able to control the log level of camouflage's console logger testinggospels/camouflage#244 We can't redirect stdout/stderr to a PIPE since on successful startup the PIPE would fill and block camouflage. On the other hand sending stdout/stderr to /dev/null prevents users from seeing errors from the shell/OS regarding camouflage failing to start.
mdemoret-nv
approved these changes
Dec 20, 2023
mdemoret-nv
added this to the 24.03 - Dependencies, Build System, and CI Improvements milestone
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes three issues:
/dev/null. This was fixed by redirecting stdout/stderr to a file, and displaying the content on failure.This is a work-around for not being able to control the log level of camouflage's console logger:
testinggospels/camouflage#244
We can't redirect stdout/stderr to a PIPE since on successful startup the PIPE would fill and block camouflage.
Closes #1417
By Submitting this PR I confirm: