Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor verification of optional dependencies #1443

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Dec 18, 2023

Description

  • Rather than checking keys in the globals() dictionary, check if the exception is not-None
  • Remove morpheus/utils/verify_dependencies.py

Closes #1435

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner December 18, 2023 19:57
@dagardner-nv dagardner-nv self-assigned this Dec 18, 2023
@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Dec 18, 2023
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 77cbffe into nv-morpheus:branch-24.03 Dec 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: re-work _verify_deps to key off of the import exception
2 participants