Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally skip ci based on a label in the pr #1444

Merged
merged 17 commits into from
Dec 20, 2023
Merged

Optionally skip ci based on a label in the pr #1444

merged 17 commits into from
Dec 20, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Dec 19, 2023 •
edited
Loading

Description

  • Adds a get-pr-info job at the head of the pipeline which examines the labels on the PR.
  • If the PR contains the skip-ci label, the rest of the jobs in the CI pipeline are skipped.
  • This avoids the requirement to include [no ci] in commit comments.
  • After the label is removed CI will execute on the next push.

Closes #1183

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv self-assigned this Dec 19, 2023
@dagardner-nv dagardner-nv requested a review from a team as a code owner December 19, 2023 00:12
@dagardner-nv dagardner-nv marked this pull request as draft December 19, 2023 00:13
@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality skip-ci Optionally Skip CI for this PR labels Dec 19, 2023
@dagardner-nv dagardner-nv removed the skip-ci Optionally Skip CI for this PR label Dec 19, 2023
@dagardner-nv
Copy link
Contributor Author

/ok to test

@dagardner-nv dagardner-nv marked this pull request as ready for review December 19, 2023 16:29
mdemoret-nv
mdemoret-nv approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 8d8842b into nv-morpheus:branch-24.03 Dec 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Create a 'skip-ci' label
2 participants
@dagardner-nv @mdemoret-nv