Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install headers & morpheus-config.cmake #1448

Merged
merged 107 commits into from
Jan 22, 2024
Merged

Install headers & morpheus-config.cmake #1448

merged 107 commits into from
Jan 22, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Dec 28, 2023 •
edited
Loading

Description

  • Allows users to create C++ stages/messages without a source code checkout of morpheus.
  • Explicitly install cpython extensions as a part of the python install.
  • Remove usage of YAPF_EXCLUDE_FLAGS work-around for an old yapf bug which has been fixed in our current version.
  • Update C++ developer guide examples to optionally build independently of morpheus.
  • Install versioneer as a conda package, remove in-repo copy of versioneer.py

Closes #331

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

mdemoret-nv and others added 19 commits July 26, 2023 19:43
@mdemoret-nv
Making the morpheus project relocatable to support building C++ compo…
bae8984 
…nents
@mdemoret-nv
Improving the install step
bfd3098
@mdemoret-nv
Removing -core from utilities
e2cc0bb
@dagardner-nv
Update morpheus utils
8bc32c1
@dagardner-nv
Merge branch 'branch-24.03' of github.com:nv-morpheus/Morpheus into d…
de526c0 
…avid-mdd_relocatable-package
@dagardner-nv
Fix merge error
7ee8b02
@dagardner-nv
Track mdd_improve-setup
ba3cd1f
@dagardner-nv
Updated mdd_improve-setup branch
9863c39
@dagardner-nv
Updated utilities repo
79263f3
@dagardner-nv
Merge branch 'branch-24.03' of github.com:nv-morpheus/Morpheus into d…
f6fa607 
…avid-mdd_relocatable-package
@dagardner-nv
Import mrc.core.segment to avoid stubgen error regarding ObjectProper…
eb4d62c 
…ties not being defined
@dagardner-nv
Remove unused import
dab8e20
@dagardner-nv
Update stage to match type refactor
0b7f31c
@dagardner-nv
Update stub file
6478686
@dagardner-nv
Add test for the external_cpp_stage
5f021a9
@dagardner-nv
Only install the cpython extensions into site-packages, avoids redund…
261b298 
…ant/unused copy of libmorpheus.so
@dagardner-nv
Ignore _version.py
d3f79c6
@dagardner-nv
Add license header, remove redundant lines
c243209
@dagardner-nv
Yapf issue nv-morpheus#984 has been fixed in our current version of y…
8d531d5 
…apf. Remove usage of older YAPF_EXCLUDE_FLAGS work-around
@dagardner-nv dagardner-nv added non-breaking Non-breaking change feature request New feature or request improvement Improvement to existing functionality skip-ci Optionally Skip CI for this PR labels Dec 28, 2023
@dagardner-nv dagardner-nv self-assigned this Dec 28, 2023
@dagardner-nv dagardner-nv requested review from a team as code owners December 28, 2023 00:22
@dagardner-nv dagardner-nv removed the improvement Improvement to existing functionality label Dec 28, 2023
This was referenced Jan 10, 2024
Merged
Merged
cwharris
cwharris requested changes Jan 12, 2024
View reviewed changes
cmake/dependencies.cmake Show resolved Hide resolved
cmake/dependencies.cmake Outdated Show resolved Hide resolved
@cwharris cwharris mentioned this pull request Jan 12, 2024
Closed
3 tasks
@dagardner-nv dagardner-nv mentioned this pull request Jan 17, 2024
Closed
mdemoret-nv
mdemoret-nv requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there. Some questions and minor cleanup items

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
ci/scripts/python_checks.sh Show resolved Hide resolved
cmake/package_search/Finducx.cmake Outdated Show resolved Hide resolved
morpheus/_lib/cmake/libmorpheus.cmake Show resolved Hide resolved
morpheus/_lib/cmake/libmorpheus.cmake Outdated Show resolved Hide resolved
morpheus/_lib/cmake/libmorpheus.cmake Outdated Show resolved Hide resolved
morpheus/_lib/cmake/libmorpheus.cmake Outdated Show resolved Hide resolved
morpheus/_lib/cmake/libmorpheus.cmake Outdated Show resolved Hide resolved
mdemoret-nv
mdemoret-nv approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we confirm whether or not the UCX file is being used, this should be good to go.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c0237fe into nv-morpheus:branch-24.03 Jan 22, 2024
9 checks passed
@dagardner-nv dagardner-nv deleted the david-mdd_relocatable-package branch January 22, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Allow users to write, compile, and load custom sources/stages/sinks without recompiling all of morpheus
3 participants
@dagardner-nv @cwharris @mdemoret-nv