Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GNN fraud detection notebook fix #1450

Merged
merged 7 commits into from
Jan 17, 2024
Merged

GNN fraud detection notebook fix #1450

merged 7 commits into from
Jan 17, 2024

Conversation

efajardo-nv
Copy link
Contributor

Description

  • Add notebook fixes from @tzemicheal
  • Migrate remaining pandas code to cudf

Closes #1265

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change labels Jan 2, 2024
@efajardo-nv efajardo-nv requested a review from a team as a code owner January 2, 2024 21:19
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

tzemicheal
tzemicheal approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@tzemicheal tzemicheal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is LGTM!

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 05d6747 into nv-morpheus:branch-24.03 Jan 17, 2024
8 checks passed
@mdemoret-nv mdemoret-nv deleted the gnn-training-notebook-fix branch January 17, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv left review comments

@tzemicheal tzemicheal tzemicheal approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Missing map_node_id in GNN Fraud Detection training notebook
3 participants
@efajardo-nv @mdemoret-nv @tzemicheal