Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana log monitoring and error alerting example #1463

Merged
merged 21 commits into from
Feb 15, 2024

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Jan 10, 2024

Description

  • Add Loki service to production DFP docker-compose
  • Add Loki data source to Grafana
  • Add DFP Logs dashboard to Grafana
  • Pipeline run script that uses Loki logging handler
  • Update README for Grafana DFP Example
  • Add instructions for setting up error alerting in Grafana
  • Update Morpheus logger to accept additional handlers so that we can add the Loki handler.

Closes #1336

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added non-breaking Non-breaking change improvement Improvement to existing functionality dfp [Workflow] Related to the Digital Fingerprinting (DFP) workflow labels Jan 10, 2024
@efajardo-nv efajardo-nv marked this pull request as ready for review January 16, 2024 19:28
@efajardo-nv efajardo-nv requested a review from a team as a code owner January 16, 2024 19:28
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comment about updating configure_logging we will need:

  1. Tests to ensure new loggers function correctly
  2. Docs showing how to add a new logger
  3. Possibly a standalone example

examples/digital_fingerprinting/production/grafana/run.py Outdated Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 9cd8863 into nv-morpheus:branch-24.03 Feb 15, 2024
9 checks passed
@mdemoret-nv mdemoret-nv deleted the loki-error-logging branch February 15, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dfp [Workflow] Related to the Digital Fingerprinting (DFP) workflow improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Pipeline error alerting and progress monitoring
2 participants