Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expected JSON config file extension in logger #1471

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Fix expected JSON config file extension in logger #1471

merged 2 commits into from
Jan 17, 2024

Conversation

efajardo-nv
Copy link
Contributor

Description

  • Fixes bug in logger where it was looking for json instead of .json when passing JSON config file.

Fixes #1470

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change labels Jan 17, 2024
@efajardo-nv efajardo-nv requested a review from a team as a code owner January 17, 2024 17:59
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 0e0737f into nv-morpheus:branch-24.03 Jan 17, 2024
9 checks passed
@mdemoret-nv mdemoret-nv deleted the morpheus-logger-fix branch January 17, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

function running into errors when passing 'json' file.
2 participants
@efajardo-nv @mdemoret-nv