Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCA Source Stage improvements #1475

Merged
merged 18 commits into from
Mar 22, 2024
Merged

DOCA Source Stage improvements #1475

merged 18 commits into from
Mar 22, 2024

Conversation

e-ago
Copy link
Contributor

@e-ago e-ago commented Jan 22, 2024

Upgrade DOCA source stage API from 2.2 to 2.5 + code restyle

Waiting on

  1. breaking conda-build feature request
    cwharris
  2. breaking conda-build feature request

@e-ago e-ago requested a review from a team as a code owner January 22, 2024 15:38
Copy link

copy-pr-bot bot commented Jan 22, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jarmak-nv jarmak-nv added non-breaking Non-breaking change enhancement Additional functionality added to an existing feature improvement Improvement to existing functionality and removed enhancement Additional functionality added to an existing feature labels Jan 22, 2024
Upgrade DOCA source stage API from 2.2 to 2.5

Signed-off-by: Elena Agostini <[email protected]>
Several features added:
- Possibility to chose between UDP or TCP traffic
- Receiver kernel now is persistent
- Multiple queues enabled (load balancing of traffic)

Signed-off-by: Elena Agostini <[email protected]>
@e-ago e-ago changed the title Upgrade DOCA 2.5 API DOCA Source Stage improvements Jan 24, 2024
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good outside of styles and leftover commented code. To get this passing CI you will need to run ./ci/scripts/fix_all.sh from the Morpheus repository root with the Morpheus conda environment activated. That will adjust code styles, which means you will need to make a new commit. If there are still issues with CI, we can look in to them more closesly, and depending on how involved they are I may be able to make the updates.

You will also need to merge latest.

docker/run_container_dev.sh Outdated Show resolved Hide resolved
docker/run_container_dev.sh Outdated Show resolved Hide resolved
morpheus/_lib/doca/include/doca_context.hpp Outdated Show resolved Hide resolved
morpheus/_lib/doca/include/doca_rx_pipe.hpp Outdated Show resolved Hide resolved
morpheus/_lib/doca/include/doca_semaphore.hpp Outdated Show resolved Hide resolved
morpheus/_lib/doca/src/doca_source.cpp Outdated Show resolved Hide resolved
morpheus/_lib/doca/src/doca_source.cpp Outdated Show resolved Hide resolved
morpheus/_lib/doca/src/doca_source_kernels.cu Outdated Show resolved Hide resolved
morpheus/_lib/doca/src/doca_source_kernels.cu Outdated Show resolved Hide resolved
morpheus/_lib/doca/src/doca_source_kernels.cu Outdated Show resolved Hide resolved
@e-ago e-ago requested review from a team as code owners March 11, 2024 14:01
@e-ago
Copy link
Contributor Author

e-ago commented Mar 11, 2024

Created 3 issues to keep track of the status: 2 bugs and 1 feature

#1557
#1558
#1559

Addressed all commits, can't run CI. Sent error stack via Slack message

@mdemoret-nv
Copy link
Contributor

/ok to test

@cwharris
Copy link
Contributor

/ok to test

@cwharris
Copy link
Contributor

/ok to test

@cwharris
Copy link
Contributor

/ok to test

@cwharris
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit b939b3d into nv-morpheus:branch-24.03 Mar 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants