Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ControlMessage output in the C++ impl of DeserializeStage #1478

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jan 24, 2024

Description

  • C++ impl of DeserializeStage now templates the output message type
  • Add the ability to cast a Python instance of a MessageMeta to the C++ instance of MessageMeta. This removes the need to explicitly import the C++ impl of MessageMeta in order to set the payload of a ControMessage.
  • Use C++ mode by default for LLM examples
  • Support cudf DataFrames for both WebScraperStage and RSSController
  • utility method show_warning_message now marked visible in lib
  • Move tests/test_deserialize_stage_pipe.py -> tests/stages/test_deserialize_stage_pipe.py & tests/test_message_meta.py -> tests/messages/test_message_meta.py
  • Update docstrings

Closes #1328
Closes #1480
Closes #1481
Closes #1342

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality DO NOT MERGE PR should not be merged; see PR for details skip-ci Optionally Skip CI for this PR labels Jan 24, 2024
@dagardner-nv dagardner-nv self-assigned this Jan 24, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner January 24, 2024 22:24
@dagardner-nv dagardner-nv marked this pull request as draft January 24, 2024 22:25
@dagardner-nv dagardner-nv removed the skip-ci Optionally Skip CI for this PR label Jan 25, 2024
@dagardner-nv dagardner-nv removed the DO NOT MERGE PR should not be merged; see PR for details label Jan 25, 2024
@dagardner-nv dagardner-nv marked this pull request as ready for review January 25, 2024 23:59
@dagardner-nv dagardner-nv marked this pull request as draft January 26, 2024 00:06
@dagardner-nv dagardner-nv marked this pull request as ready for review January 26, 2024 00:44
Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I would like to hold off until the vdb_upload PR goes in.

examples/llm/vdb_upload/pipeline.py Outdated Show resolved Hide resolved
@dagardner-nv dagardner-nv marked this pull request as draft January 26, 2024 18:00
@dagardner-nv dagardner-nv requested a review from a team as a code owner January 29, 2024 18:28
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 77cc0e5 into nv-morpheus:branch-24.03 Feb 12, 2024
10 checks passed
@dagardner-nv dagardner-nv deleted the david-deserialize-control-message-1328 branch February 12, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
3 participants