Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime environment output to fix building the release container #1496

Merged
merged 72 commits into from
Feb 7, 2024

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Feb 6, 2024

Description

Fixes the release container build.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@cwharris cwharris added bug Something isn't working non-breaking Non-breaking change labels Feb 6, 2024
@cwharris cwharris marked this pull request as ready for review February 6, 2024 14:40
@cwharris cwharris requested review from a team as code owners February 6, 2024 14:40
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm that we are using the new environments in conda/environments and all references to docker/conda has been removed.

docker/Dockerfile Outdated Show resolved Hide resolved
docker/build_container.sh Show resolved Hide resolved
@cwharris
Copy link
Contributor Author

cwharris commented Feb 6, 2024

Addressed the feedback and opened #1497. We'll need to work with the data science team to make sure we get this updated properly, so suggest we go ahead and merge this PR.

@mdemoret-nv mdemoret-nv changed the title Fix release container Add runtime environment output to fix building the release container Feb 7, 2024
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 6388da1 into nv-morpheus:branch-24.03 Feb 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants