Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix intermittent segfault on interpreter shutdown #1513

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Fix intermittent segfault on interpreter shutdown #1513

merged 3 commits into from
Feb 13, 2024

Conversation

dagardner-nv
Copy link
Contributor

Description

  • Remove static reference to the cupy python module in CupyUtil which was causing a segfault on interpreter shutdown.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Feb 12, 2024
@dagardner-nv dagardner-nv self-assigned this Feb 12, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner February 12, 2024 23:10
drobison00
drobison00 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and fixes the segfault for me too.

@drobison00
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit e30fe76 into nv-morpheus:branch-24.03 Feb 13, 2024
13 checks passed
@dagardner-nv dagardner-nv deleted the david-tensor-memory-update branch February 13, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drobison00 drobison00 drobison00 approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dagardner-nv @drobison00