Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make start_async() available to source stages #1523

Merged

Conversation

efajardo-nv
Copy link
Contributor

Description

  • Moves start_async from Stage to StageBase to make it available to source stages.
  • Adds tests for source stage start_async and on_start.

Closes #1522

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change labels Feb 16, 2024
@efajardo-nv efajardo-nv self-assigned this Feb 16, 2024
@efajardo-nv efajardo-nv requested a review from a team as a code owner February 16, 2024 18:13
@mdemoret-nv mdemoret-nv added breaking Breaking change and removed non-breaking Non-breaking change labels Feb 21, 2024
@mdemoret-nv mdemoret-nv changed the title Make start_async available to source stages Make start_async() available to source stages Feb 21, 2024
morpheus/pipeline/pipeline.py Outdated Show resolved Hide resolved
tests/pipeline/test_pipeline.py Outdated Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 65552f5 into nv-morpheus:branch-24.03 Feb 22, 2024
9 checks passed
@efajardo-nv efajardo-nv deleted the source-stage-start-async branch July 29, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: The on_start method is not called on source stages
2 participants