Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade openai version to 1.13 and langchain to version 0.1.9 #1529

Merged
merged 29 commits into from
Feb 27, 2024
Merged

Upgrade openai version to 1.13 and langchain to version 0.1.9 #1529

merged 29 commits into from
Feb 27, 2024

Conversation

mdemoret-nv
Copy link
Contributor

@mdemoret-nv mdemoret-nv commented Feb 21, 2024 •
edited by dagardner-nv
Loading

Description

This PRs main focus is to update the version of the OpenAI package to 1.13 to allow using the built in retry logic and improved code. In addition, the following changes are also made:

  • Switch to using langchain==0.1.9 installed via pip to get around pandas dependency issue
  • Sorted the lists in dependencies.yaml to make merging easier in the future
  • Improved logging for the OpenAILlmService to log all requests ordered to a file
  • New feature to add default model arguments to the service to avoid repeating arguments for each client. You can now just overwrite the default args
  • New feature to allow the run_ci_local.sh to persist any changes to the code back to the host via a volume mount.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@mdemoret-nv mdemoret-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Feb 21, 2024
@mdemoret-nv mdemoret-nv requested review from a team as code owners February 21, 2024 00:54
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 22, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mdemoret-nv
Copy link
Contributor Author

/ok to test

@mdemoret-nv
Copy link
Contributor Author

/ok to test

dagardner-nv
dagardner-nv approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had a few questions

morpheus/llm/services/openai_chat_service.py Outdated Show resolved Hide resolved
morpheus/stages/inference/inference_stage.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor Author

/ok to test

@mdemoret-nv mdemoret-nv added breaking Breaking change and removed non-breaking Non-breaking change labels Feb 23, 2024
@dagardner-nv dagardner-nv changed the title Upgrade openai version to 1.13 and langchain to version 0.0.310 Upgrade openai version to 1.13 and langchain to version 0.1.9 Feb 23, 2024
@mdemoret-nv
Copy link
Contributor Author

/ok to test

@mdemoret-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 594b10c into nv-morpheus:branch-24.03 Feb 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagardner-nv dagardner-nv dagardner-nv approved these changes

Assignees
No one assigned
Labels
breaking Breaking change improvement Improvement to existing functionality
Projects
Morpheus Boards
Archived in project
Milestone
24.03 - Sherlock Improvements
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdemoret-nv @dagardner-nv