Fix pathlib.Path support for FileSourceStage #1531

dagardner-nv · 2024-02-22T22:45:16Z

Description

The type hint for the filename argument to the FileSourceStage is pathlib.Path, however this is incompatible with the C++ impl and the determine_file_type method.
Closes [BUG]: Using pathlib.Path for the filename parameter for FileSourceStage breaks file type inference #1530

I am familiar with the Contributing Guidelines.
When the PR is ready for review, new or existing tests cover these changes.
When the PR is ready for review, the documentation is up to date with these changes.

…ython bindings for the file source stage

morpheus/_lib/stages/module.cpp

dagardner-nv · 2024-02-29T17:18:02Z

/merge

dagardner-nv added 4 commits February 22, 2024 12:34

Add test param for nv-morpheus#1530

08ed2a0

Add test for determine_file_type

a1c5d00

Add std::filesystem::path overrides for determine_file_type and the p…

53b7749

…ython bindings for the file source stage

IWYU fixes

d92cc76

dagardner-nv requested a review from a team as a code owner February 22, 2024 22:45

dagardner-nv self-assigned this Feb 22, 2024

dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Feb 22, 2024

mdemoret-nv approved these changes Feb 28, 2024

View reviewed changes

morpheus/_lib/stages/module.cpp Outdated Show resolved Hide resolved

dagardner-nv and others added 2 commits February 28, 2024 12:45

Remove old comment

89b45f9

Merge branch 'branch-24.03' into david-file-source-type-detect

19a99bd

rapids-bot bot merged commit a07f82f into nv-morpheus:branch-24.03 Feb 29, 2024
9 checks passed

dagardner-nv deleted the david-file-source-type-detect branch February 29, 2024 17:22