Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch langchain agent errors #1539

Merged
merged 14 commits into from
Mar 11, 2024
Merged

Catch langchain agent errors #1539

merged 14 commits into from
Mar 11, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Feb 29, 2024 •
edited
Loading

Description

  • Catch any uncaught/un-handled langchain agent errors, return an error string so that we don't end up with a missing result.
  • Fix version conflicts for nemollm and dgl
  • Expand existing tests for the LangChainAgentNode

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Feb 29, 2024
@dagardner-nv dagardner-nv self-assigned this Feb 29, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner February 29, 2024 17:39
@dagardner-nv dagardner-nv marked this pull request as draft March 8, 2024 23:43
@dagardner-nv dagardner-nv marked this pull request as ready for review March 11, 2024 18:34
@dagardner-nv dagardner-nv requested a review from a team as a code owner March 11, 2024 18:34
This was referenced Mar 11, 2024
Closed
Closed
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a844794 into nv-morpheus:branch-24.03 Mar 11, 2024
10 checks passed
@dagardner-nv dagardner-nv deleted the david-agent-error branch March 11, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dagardner-nv @cwharris @mdemoret-nv