Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iso_date_regex_pattern config in file_batcher module and allow override #1580

Merged
merged 7 commits into from
Mar 27, 2024
Merged

Fix iso_date_regex_pattern config in file_batcher module and allow override #1580

merged 7 commits into from
Mar 27, 2024

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Mar 25, 2024 •
edited
Loading

Description

  • Update file_batchermodule to use documented module config key iso_date_regex_pattern instead of batch_iso_date_regex_pattern.
  • Allow override of iso_date_regex_pattern with control message.
  • Add tests for file_batcher module

Closes #1576
Closes #1577

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change labels Mar 25, 2024
@efajardo-nv efajardo-nv self-assigned this Mar 25, 2024
@efajardo-nv efajardo-nv requested a review from a team as a code owner March 25, 2024 14:26
mdemoret-nv
mdemoret-nv requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine but we need to add a test to guarantee its working in the future.

mdemoret-nv
mdemoret-nv approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests look excellent! Thank you

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 1fc9588 into nv-morpheus:branch-24.03 Mar 27, 2024
10 checks passed
@efajardo-nv efajardo-nv deleted the file-batcher-date-regex-fix branch July 29, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@efajardo-nv efajardo-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
2 participants
@efajardo-nv @mdemoret-nv