Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCA 2.6 from public repo #1588

Merged
merged 11 commits into from
Apr 5, 2024
Merged

DOCA 2.6 from public repo #1588

merged 11 commits into from
Apr 5, 2024

Conversation

e-ago
Copy link
Contributor

@e-ago e-ago commented Apr 3, 2024

Description

Modified the Dockerfile if DOCA is enabled to install with apt DOCA debian packages from public repo instead of the internal repo

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@e-ago e-ago requested a review from a team as a code owner April 3, 2024 12:28
Copy link

copy-pr-bot bot commented Apr 3, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: eagostini <[email protected]>
@e-ago
Copy link
Contributor Author

e-ago commented Apr 3, 2024

@mdemoret-nv I've applied your comments

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv mdemoret-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Apr 3, 2024
@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/ok to test

@e-ago e-ago requested a review from a team as a code owner April 5, 2024 02:50
@mdemoret-nv
Copy link
Contributor

/ok to test

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have built the new release and dev container with DOCA support. Release container has been tested by @e-ago. Approved.

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 9e1e992 into nv-morpheus:branch-24.03 Apr 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants