Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-json serializable objects in LLMContext #1589

Merged
merged 54 commits into from
Apr 5, 2024
Merged

Support non-json serializable objects in LLMContext #1589

merged 54 commits into from
Apr 5, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Apr 3, 2024 •
edited
Loading

Description

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv
Revert to returning the exception rather than an error string
46bd47e
@dagardner-nv
WIP
bb3fa5c
@dagardner-nv
Update testt, inside of LLMContext::pop() are three if/else branches,…
e2db600 
… when the context has no output names or only one output name, then the values are std::moved, otherwise the values are copied I think this is a bug, I fixed it and updated the test to match
@dagardner-nv
Add new overrides for set_output
63112e1
@dagardner-nv
Remove unused values member
5e5723b
@dagardner-nv
WIP
ec19a84
@dagardner-nv
Add find_input method
413d92c
@dagardner-nv
Overload push and pop
7b4d82f
@dagardner-nv
Fix return type
fd37364
@dagardner-nv
Remove leading / prior to fetching, ensure we have the gil when we ne…
a1e435b 
…ed it, fix capturing of key-error
@dagardner-nv
Cast the context and use the python version of set_output
91c1023
@dagardner-nv
Use a type hint so VSCode won't warn that df is None
b344ef4
@dagardner-nv
Inform python bindings of the base class
1e7efc3
@dagardner-nv
Ensure we get a python context when we need one
fec0e9b
@dagardner-nv
Use get_python to ensure nested objects are fetched
38450a3
@dagardner-nv
Remove unnecessary caching
b225573
@dagardner-nv
Remove redundant json methods
e34b05a
@dagardner-nv
Update stub
07e4e48
@dagardner-nv
replace usage of dynamic_pointer_cast with MRC_PTR_CAST
6b307fa
@dagardner-nv
wip
026497e
@dagardner-nv
Adopt nlohmann_json 3.11
4cd7280
@dagardner-nv
WIP
4015df7
@dagardner-nv
WIP
c1c8bad
@dagardner-nv
Remove py wrappers, instead define a pybind11 cast
4514fae
@dagardner-nv
Uncomment LLMContext mapping
98c4ee4
@dagardner-nv
Pybind caster for jsonvalues
981bd3b
@dagardner-nv
Python None should be a json null
151c275
@dagardner-nv
WIP
894857c
@dagardner-nv
WIP: Tests compiling now
57389fa
@dagardner-nv
Fix impl for get_inputs
98b2fbe
@dagardner-nv dagardner-nv requested review from a team as code owners April 3, 2024 15:33
@dagardner-nv dagardner-nv mentioned this pull request Apr 3, 2024
Closed
@dagardner-nv dagardner-nv added dependencies Pull requests that update a dependency file breaking Breaking change improvement Improvement to existing functionality Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order sherlock Issues/PRs related to Sherlock workflows and components skip-ci Optionally Skip CI for this PR labels Apr 3, 2024
@dagardner-nv dagardner-nv changed the base branch from branch-24.03 to branch-24.06 April 3, 2024 15:52
mdemoret-nv
mdemoret-nv approved these changes Apr 3, 2024
View reviewed changes
morpheus/_lib/include/morpheus/pybind11/json_values.hpp Outdated Show resolved Hide resolved
morpheus/_lib/include/morpheus/pybind11/json_values.hpp Outdated Show resolved Hide resolved
morpheus/_lib/src/llm/llm_context.cpp Outdated Show resolved Hide resolved
@dagardner-nv dagardner-nv removed skip-ci Optionally Skip CI for this PR Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order labels Apr 5, 2024
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 39f7f73 into nv-morpheus:branch-24.06 Apr 5, 2024
9 checks passed
@dagardner-nv dagardner-nv deleted the david-langchain-agent-errors-p2 branch April 5, 2024 16:54
@yczhang-nv yczhang-nv mentioned this pull request Apr 15, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
breaking Breaking change dependencies Pull requests that update a dependency file improvement Improvement to existing functionality sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Update LLMContext to store outputs that are not json serializable
2 participants
@dagardner-nv @mdemoret-nv