Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc CI improvements #1618

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Apr 11, 2024

Description

  • Fetch git tags when performing documentation builds. Allowing for the version number to appear properly in the generated documentation. This should allow for us to publish the documentation build from CI when performing a release.
  • Allow overriding the GIT_URL, useful when performing CI against a commit/branch/tag that exists in a remote other than origin
  • Replace list of CUDA architectures with RAPIDS place-holder (we were building for 60 even though we no longer support it)
  • Construct the CMAKE_BUILD_ALL_FEATURES var in a more readable way
  • Allow overriding the build dir, useful for local builds using USE_HOST_GIT=1 to avoid conflicting with a potentially existing build directory
  • Move generated env.yaml to $WORKSPACE_TMP, prevents the file from being written to the root of the git repo.
  • Rather than init submodules in each stage by hand, use the submodules flag in the checkout action

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

…lows for the version number to appear propperly in the generated documentation
…mit/branch/tag that exists in a remote other than origin
…t the CMAKE_BUILD_ALL_FEATURES var in a more readable way, consolidate repeated flags into CMAKE_BUILD_ALL_FEATURES, allow overriding of the build dir.
@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality conda-build Enables running the conda-build step on a PR labels Apr 11, 2024
@dagardner-nv dagardner-nv self-assigned this Apr 11, 2024
@dagardner-nv dagardner-nv requested review from a team as code owners April 11, 2024 16:28
@dagardner-nv dagardner-nv marked this pull request as draft April 11, 2024 16:28
@dagardner-nv dagardner-nv marked this pull request as ready for review April 12, 2024 16:34
.github/workflows/ci_pipe.yml Show resolved Hide resolved
ci/scripts/github/common.sh Outdated Show resolved Hide resolved
ci/scripts/github/checks.sh Show resolved Hide resolved
ci/scripts/run_ci_local.sh Outdated Show resolved Hide resolved
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 6b9cb71 into nv-morpheus:branch-24.06 Apr 18, 2024
11 checks passed
@dagardner-nv dagardner-nv deleted the david-local-ci-improvements branch April 18, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda-build Enables running the conda-build step on a PR improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants