Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests to detect issue #1626 #1629

Merged
merged 8 commits into from
Apr 24, 2024
Merged

Fix tests to detect issue #1626 #1629

merged 8 commits into from
Apr 24, 2024

Conversation

dagardner-nv
Copy link
Contributor

Description

  • PR Control MonitorStage output with the log-level #659 inadvertently excluded the monitor stage from several of the end-to-end pipeline tests.
  • Adds an environment variable MORPHEUS_MONITOR_ALWAYS_ENABLED which when set, will force the monitor stage to always be enabled.
  • Adds an auto-use fixture monitor_stage_always_enabled which ensures the environment variable is set & present.

Requires nv-morpheus/MRC#473 to be merged first

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order labels Apr 16, 2024
@dagardner-nv dagardner-nv self-assigned this Apr 16, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner April 16, 2024 18:33
@dagardner-nv dagardner-nv removed the Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order label Apr 16, 2024
cwharris
cwharris approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mdemoret-nv
mdemoret-nv requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See how many changes would be necessary to just change the constructor arg for the MonitorStage so it is used by the tests.

@dagardner-nv dagardner-nv marked this pull request as draft April 18, 2024 14:57
@dagardner-nv dagardner-nv added the skip-ci Optionally Skip CI for this PR label Apr 18, 2024
@dagardner-nv dagardner-nv removed the skip-ci Optionally Skip CI for this PR label Apr 18, 2024
@dagardner-nv dagardner-nv marked this pull request as ready for review April 18, 2024 22:21
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit ec18300 into nv-morpheus:branch-24.06 Apr 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dagardner-nv @mdemoret-nv @cwharris