Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in the devcontainer base image #1638

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Apr 17, 2024

Description

Closes #1624, where the devcontainer fails to build due to a mis-typed base container.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@cwharris cwharris added bug Something isn't working non-breaking Non-breaking change labels Apr 17, 2024
@cwharris cwharris requested a review from a team as a code owner April 17, 2024 19:57
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run this I have to manually run the conda install script. That used to run as a post attach step, right?

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 82ce14c into nv-morpheus:branch-24.06 Apr 19, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: DevContainer build is broken after RAPIDS 24.02 and CUDA 12.1 upgrade
2 participants