-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devcontainer to use latest build utils #1658
Update devcontainer to use latest build utils #1658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the description of the PR to include a summary of the changes.
I had a few questions, but otherwise OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried out this PR, have a couple of notes:
- When opening the container for the first time, I got the error message that the workspace folder does not exist.
- I got the message "Visual Studio Code is unable to watch for file changes in this large workspace" (error ENOSPC). See link for resolving this
- We may want to exclude some of the subdirectories in
.cache
from being watched for file changes since it contains the conda repo and a bunch of other files that arent source code. You can do that with the setting"files.watcherExclude"
- The extensions should be updated. A good set would be to use the following:
"cschlosser.doxdocgen", // Adding docstrings to C++ code
"eamodio.gitlens", // Enhanced Git support
"eeyore.yapf", // Python code formatter
"josetr.cmake-language-support-vscode", // CMake language support
"llvm-vs-code-extensions.vscode-clangd", // Clangd language server for C++
"matepek.vscode-catch2-test-adapter",
"mechatroner.rainbow-csv", // Colorizing CSV files
"mhutchie.git-graph", // Visualizing Git history and branching
"ms-azuretools.vscode-docker", // Docker support
"ms-python.debugpy", // Python debugger
"ms-python.flake8", // Python linter
"ms-python.isort", // Python import sorter
"ms-python.pylint", // Python linter
"ms-python.python", // Python language support
"ms-python.vscode-pylance", // Python language server
"ms-toolsai.jupyter", // Jupyter notebook support
"ms-vscode.cmake-tools", // CMake support for building Morpheus
"ms-vscode.cpptools", // C++ language support
"njpwerner.autodocstring", // Adding docstrings to python code
"nvidia.nsight-vscode-edition", // CUDA integration and debugging
"stkb.rewrap", // Wrapping all text in any language
"vadimcn.vscode-lldb" // LLDB debugger (better than GDB for C++ debugging)
- The conda environment should be automatically installed or updated.
Remove the |
/merge |
Description
By Submitting this PR I confirm: