Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation for building examples #1659

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix documentation for building examples #1659

merged 1 commit into from
Apr 23, 2024

Conversation

dagardner-nv
Copy link
Contributor

Description

  • The Morpheus python package needs to be built and installed prior to building the examples, updated documentation to ensure -DMORPHEUS_PYTHON_PERFORM_INSTALL=ON is added

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner April 23, 2024 17:09
@dagardner-nv dagardner-nv self-assigned this Apr 23, 2024
@dagardner-nv dagardner-nv added non-breaking Non-breaking change doc Improvements or additions to documentation ! - Hotfix Related to a Hotfix Release labels Apr 23, 2024
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c65a2e1 into nv-morpheus:branch-24.03 Apr 23, 2024
14 of 15 checks passed
@dagardner-nv dagardner-nv deleted the david-doc-fix-build-examples branch April 23, 2024 18:08
@pdmack
Copy link
Contributor

pdmack commented Apr 23, 2024

missed two:
https://github.com/nv-morpheus/Morpheus/blob/cbfea7d6708ad9f45ff41997b19ccd149773395b/examples/developer_guide/4_rabbitmq_cpp_stage/README.md?plain=1#L32C31-L32C54

@dagardner-nv
Copy link
Contributor Author

@pdmack I updated that file, that's an older commit hash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
! - Hotfix Related to a Hotfix Release doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dagardner-nv @pdmack @mdemoret-nv