Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring consistent use of the export macro MORPHEUS_EXPORT #1672

Merged
merged 13 commits into from
May 9, 2024
Merged

Ensuring consistent use of the export macro MORPHEUS_EXPORT #1672

merged 13 commits into from
May 9, 2024

Conversation

aserGarcia
Copy link
Contributor

Description

This PR makes exporting symbols consistent across header files. The docs and examples for the developer_guide is also updated.

Closes #1595

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@aserGarcia aserGarcia requested a review from a team as a code owner April 30, 2024 15:23
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 30, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mdemoret-nv mdemoret-nv changed the title #1595 MORPHEUS_EXPORT Consistency Ensuring consistent use of the export macro MORPHEUS_EXPORT May 1, 2024
@mdemoret-nv
Copy link
Contributor

/ok to test

mdemoret-nv
mdemoret-nv requested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment and we can merge. Thanks for the PR!

  • All uses of #include "morpheus/export.h" should be converted to #include <morpheus/export.h> when outside of the morpheus directory. One was pointed out but there are a few places this needs to be fixed

docs/source/developer_guide/guides/3_simple_cpp_stage.md Outdated Show resolved Hide resolved
morpheus/_lib/include/morpheus/messages/meta.hpp Outdated Show resolved Hide resolved
@mdemoret-nv mdemoret-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels May 1, 2024
@mdemoret-nv
Copy link
Contributor

/ok to test

@dagardner-nv
Copy link
Contributor

/ok to test

@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 9719d9f into nv-morpheus:branch-24.06 May 9, 2024
10 of 11 checks passed
@dagardner-nv
Copy link
Contributor

@aserGarcia merged, thanks for the contribution.

@aserGarcia aserGarcia deleted the issue-1595-morpheus-export branch May 9, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

@yczhang-nv yczhang-nv yczhang-nv approved these changes

Assignees
No one assigned
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Convert all uses of #pragma GCC visibility push(default) to use MORPHEUS_EXPORT
4 participants
@aserGarcia @mdemoret-nv @dagardner-nv @yczhang-nv